Skip to content

Add github workflow to validate docker compose #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mark90 merged 2 commits into from
Oct 29, 2025
Merged

Add github workflow to validate docker compose #61

Mark90 merged 2 commits into from
Oct 29, 2025

Conversation

@tjeerddie
Copy link
Contributor

@tjeerddie tjeerddie commented Oct 28, 2025 •
edited
Loading

adds a github workflow that starts the docker compose and then:

  1. waits for services to be healthy for 180 seconds
  2. checks if all services are running correctly or if they exited correctly (for rover-compose)
  3. checks the logs inside the services if they contain any errors.

closes: #51

tested with removing the federation fix, which breaks rover: workflow action
tested with an error log in orchestrator : workflow action

@tjeerddie tjeerddie force-pushed the ci-workflow-docker-compose branch from 079e293 to 67b8f8a Compare October 28, 2025 14:54
@tjeerddie tjeerddie force-pushed the ci-workflow-docker-compose branch 5 times, most recently from 3c81652 to 545e68b Compare October 29, 2025 14:10
@tjeerddie
Add checks to the docker compose test github workflow
f82614d 
- add a github workflow step after waiting for the health check, to check all services are running and didnt exit unexpectedly.
- add a github workflow step to check for error logs.
@tjeerddie tjeerddie force-pushed the ci-workflow-docker-compose branch from 545e68b to f82614d Compare October 29, 2025 14:12
Mark90
Mark90 approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@Mark90 Mark90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Mark90 Mark90 merged commit 6eb5cc3 into master Oct 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark90 Mark90 Mark90 approved these changes

@pboers1988 pboers1988 pboers1988 approved these changes

@kvklink kvklink kvklink approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Maintenance]: Add CI workflow to test spinning up docker compose

5 participants

@tjeerddie @Mark90 @pboers1988 @kvklink